fix console warning for form elements about readonly target #2555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1d673ed The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2554
As described in #2554, the issue should already be fixed in Vue version 3.5.2. However, this does not seem to be the case. I assume this might be because we are building the
sit-onyxlibrary (prod mode) and then use it in an application (dev mode). Vue might handle prod and dev mode differently.As temporary fix for our onyx users, I renamed the template refs to be different from the variable name.
I also created follow up tickets:
useTemplateRef#2556useTemplateRefbug if variable and ref name are the same #2557You can verify the fix by running the demo app and check the console.
Checklist
npx changeset addif your changes should be released as npm package (because they affect the library usage)