Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promise.min.js load on Chrome/Firefox #161 #56

Open
lohoy opened this issue Dec 10, 2024 · 1 comment
Open

promise.min.js load on Chrome/Firefox #161 #56

lohoy opened this issue Dec 10, 2024 · 1 comment

Comments

@lohoy
Copy link

lohoy commented Dec 10, 2024

Hello,

the file : Smile_Map::js/polyfill/ie11/promise.min.js load on all browser but on the layout : smile_map_styles.xml it should only be loaded on IE11.

Preconditions

Go on website which use smile map module

Magento Version : 2.4.5
Module Store Locator Version : 2.0.4
Environment : Production

Steps to reproduce

  1. Go on website which use SmileMap module
  2. See the file promise.min.js loaded on network tab

Expected result

  1. promise.min.js not loaded

Actual result

  1. promise.min.js loaded

https://i.imgur.com/XeuJnGv.png

I think the ie_condition field on layout file no longer works.

@lohoy
Copy link
Author

lohoy commented Dec 10, 2024

PR : #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant