Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validation issue #7

Open
banteg opened this issue Apr 8, 2024 · 2 comments
Open

validation issue #7

banteg opened this issue Apr 8, 2024 · 2 comments

Comments

@banteg
Copy link

banteg commented Apr 8, 2024

there are several validation issues with tokenlistooor-produced token list:

  1. instead of omitting the optional logoURI where it doesn't exist, the script populates the list with "logoURI": "" which is not a valid uri
  2. the timestamp format must be in iso format. instead of "timestamp": "08/04/2024 14:16:52" it should say 2024-08-04T14:16:52Z or 2024-08-04T14:16:52+00:00

the official json schema can be found here https://github.com/Uniswap/token-lists/blob/main/src/tokenlist.schema.json

@banteg
Copy link
Author

banteg commented Apr 8, 2024

meanwhile relaxed the checks in ape ApeWorX/py-tokenlists#39

@Majorfi
Copy link
Contributor

Majorfi commented Apr 9, 2024

Timestamp has been updated, we are checking for the logoURI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants