-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Command module loading #3
Comments
I talked to @vladfrangu about this and they suggested https://sapphiredev.github.io/framework as an alternative, the current implementation is really just something I'm familiar with that works. Of course a proper command handler is a better approach |
If Vlad wants to use his own library, he can. Given there's still like, no documentation for Sapphire aside from the auto-generated typedocs, it's not something I would suggest we use. |
Leaving aside the fact it's not my library, I don't see why that affects anything, when the entire library is so small and extensible, it only adds small helper stones... THere's also a bunch of bots already using it, whose code is OSS, so... |
Oh please, we know you contribute to it. The lack of documentation is like a really big problem - reading OSS code is only going to get some of us so far. |
From #2, @kokumaji added support for loading commands directly from the file system. This has somepotential ramifications - nothing inherently wrong with doing it, but it does come at the cost of some type safety.
We can either:
Both sides have their pros and cons, but needs discussing to work out what to do.
The text was updated successfully, but these errors were encountered: