Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Themes broken by discord. (again) #480

Closed
3 of 7 tasks
SpidFightFR opened this issue Oct 25, 2023 · 7 comments
Closed
3 of 7 tasks

CSS Themes broken by discord. (again) #480

SpidFightFR opened this issue Oct 25, 2023 · 7 comments
Assignees
Labels
type:bug Something isn't working

Comments

@SpidFightFR
Copy link

Acknowledgements

  • I have checked that there is no other issue describing the same or
    similar problem that I currently have, regardless if it has been
    closed or open.

  • This bug affects Discord website.

  • This issue is confirmed to be reproducible when WebCord is packaged
    on at least all three latest supported Electron major releases.

  • This issue is reproducible in Chrome, Chromium or any
    Chromium-based browser, e.g Brave or Edge (please write in
    Additional Context which browser you have used if it is neither
    Chrome nor unmodified Chromium).

  • There are no fixes done to master which resolves this issue.

  • My issue describes one of the unstable and/or not fully implemented
    features.

  • I have found a workaround to mitigate or temporarily fix this issue
    in affected releases (please write it in Additional context section
    below).

Operating System / Platform

🐧️ Linux

Operating system architecture

x64 (64-bit Intel/AMD)

Electron version

v27 (default flatpak)

Application version

v4.5.0

Bug description

--add-css-theme flag does nothing: it only displays the dialog window, once selected, webcord doesn't start.

Additional context

There's nothing more to say, i tried to change the rules of flatpak for webcord, but it stopped working.

@SpidFightFR SpidFightFR added the type:bug Something isn't working label Oct 25, 2023
@SpacingBat3
Copy link
Owner

SpacingBat3 commented Oct 25, 2023

--add-css-theme flag does nothing: it only displays the dialog window, once selected, webcord doesn't start.

This is intended behavior; there should be no extra WebCord instance running after you add CSS theme. It is expected WebCord is already running or you'll start WebCord after you've added a CSS theme.

@SpacingBat3 SpacingBat3 added status:invalid This doesn't seem right status:need-info Further information is requested labels Oct 25, 2023
@SpidFightFR
Copy link
Author

--add-css-theme flag does nothing: it only displays the dialog window, once selected, webcord doesn't start.

This is intended behavior; there should be no extra WebCord instance running after you add CSS theme. It is expected WebCord is already running or you'll start WebCord after you've added a CSS theme.

is it normal if it just hangs after selecting the theme ?
I must CTRL+C out of webcord...

@SpidFightFR
Copy link
Author

my bad, it actually loads for a bit before closing, but the themes don't apply, it's weird...

@SpacingBat3
Copy link
Owner

I've noticed that hiding side bar doesn't work either and WebCord's using the same API in Electron to apply any CSS mods in there, so either Electron got another regression (that would be 3rd time in row 😯) or Discord updated stuff like classes breaking themes.

@SpacingBat3 SpacingBat3 removed the status:invalid This doesn't seem right label Oct 25, 2023
@SpacingBat3 SpacingBat3 changed the title --add-css-theme does nothing. Added CSS themes aren't loaded. Oct 25, 2023
@SpacingBat3 SpacingBat3 changed the title Added CSS themes aren't loaded. Added CSS themes aren't loaded by WebCord. Oct 25, 2023
@SpacingBat3
Copy link
Owner

SpacingBat3 commented Oct 25, 2023

(In both cases, #481 is probably related to this as well.)

@SpacingBat3
Copy link
Owner

SpacingBat3 commented Oct 31, 2023

Yep, Discord most likely just broke most CSS themes just by changing the hypen to underscore in names of the CSS classes. I'll close this issue ticket since that's not WebCord's fault.

@SpacingBat3 SpacingBat3 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 31, 2023
@SpacingBat3 SpacingBat3 removed the status:need-info Further information is requested label Nov 1, 2023
@SpidFightFR SpidFightFR changed the title Added CSS themes aren't loaded by WebCord. CSS Themes broken by discord. (again) Nov 1, 2023
@SpidFightFR
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants