-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Support for other databases #1226
Comments
@Tsabo this issue was automatically closed because:
|
the bot is just gonna auto close it unless that first line is deleted |
I would be open to a PR adding support for other databases, PostgreSQL should be compatible with how we use H2. This would need to be tested with multiple different GraphQL queries, specifically each filtering option, since we do use some custom queries in H2 like the DistinctOn function. |
syer has said PostgreSQL should be possible in the discord before |
though an external DB isn't gonna be better for performance |
There is also the issue of migrations, I am not sure how that has to be handled. Maybe the plain SQL we use will be compatible, or maybe we will need migrations for each database type. |
i mean for postgres and other SQL compatable DBs migrations in plain SQL should work fine |
I'm happy that this stirred up some interest. I'll spend the weekend getting my environment set up (necessary requirements, etc..) and playing around with it. I make no promises, but I am motivated for this to be implemented. |
if u run in to any issues or need help with yr environment or whatnot you are probably best asking in the discord, stuff like that will get lost on github |
What feature should be added to Suwayomi?
The ability to use a different database other than H2.
Why/Project's Benefit/Existing Problem
Performance, third-party querying outside the API and GraphQL, and backup strategies.
It appears that you are using JetBrains Exposed for the data layer which does provide support for other databases:
https://jetbrains.github.io/Exposed/working-with-database.html#mysql
DBManager.kt#L24
I'm happy to take a look. I'm a .NET developer by day. Java isn't my thing, so I have to work through some build issues before I could do anything.
The text was updated successfully, but these errors were encountered: