Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect response to mass transfer when stellar rotation is taken into account #1308

Open
ilyamandel opened this issue Dec 10, 2024 · 0 comments
Assignees

Comments

@ilyamandel
Copy link
Collaborator

The recent implementation of accretor tidal spin up and donor tidal spindown violates the conservation of angular momentum, because I just added extra angular momentum to the accretor and removed angular momentum from the donor without accounting for a corresponding change in the angular momentum of the binary.

Basically, we are implementing the point-particle equation for binary separation evolution on mass transfer -- but, of course, if we are adding rotational angular momentum to the accretor and removing rotational angular momentum from the donor, we need to also account for those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants