Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify reference metallicity for SSE models and winds #400

Open
ilyamandel opened this issue Oct 11, 2020 · 3 comments
Open

Clarify reference metallicity for SSE models and winds #400

ilyamandel opened this issue Oct 11, 2020 · 3 comments
Assignees
Labels
question Further information is requested severity_minor This bug is not very severe urgency_low This issue is not urgent

Comments

@ilyamandel
Copy link
Collaborator

ZSOL in constants.h refers to the Hurley models, and should really be called ZREFERENCEHURLEY or some such, not ZSOL, to avoid confusion. For winds, we should go back to the individual papers — e.g., the WR scaling according to Vink & De Kotter (2005) is a relative scaling with metallicity, so the exact value of ZSOL doesn’t matter. Of course, it does matter for the prefactor — which, in Vink+ 2001, is taken as Zsol=0.019. So, if we want to fairly use these wind models, we should scale them to whatever Zsol was assumed there. [For WR winds, we already have a free multiplicative factor, so I am not too worried about those.]. Anyway, sounds like we should add an issue to go through our wind models and check that we are using the appropriate reference metallicity for each one — and do away with the ambiguous ZSOL.

@jeffriley
Copy link
Collaborator

ZSOL defined in constants.h is also the default metallicity used for SSE and BSE - used if the user does not specify metallicity via a program option or grid file.

@jeffriley jeffriley added question Further information is requested severity_minor This bug is not very severe urgency_low This issue is not urgent labels Aug 12, 2021
@ilyamandel
Copy link
Collaborator Author

Reassigning given the relevance for winds.

@ilyamandel
Copy link
Collaborator Author

@SimonStevenson and @jmerritt1 -- any thoughts on this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested severity_minor This bug is not very severe urgency_low This issue is not urgent
Projects
None yet
Development

No branches or pull requests

5 participants