Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings in Site ported to Extension #7

Open
ghost opened this issue Oct 18, 2021 · 4 comments
Open

Settings in Site ported to Extension #7

ghost opened this issue Oct 18, 2021 · 4 comments

Comments

@ghost
Copy link

ghost commented Oct 18, 2021

It would be great to have this feature. If I do have saved all settings in Webpage saved using Cookies, I think that the extension could use it and apply those Settings to the embedded Videos in other sites.

This could be possible as, Piped has already this Permission - Access your data for all web sites in the extension.

@ghost
Copy link
Author

ghost commented Nov 10, 2021

I noted in CCleaner that Piped does make a cookie this when it replaces the Video Embed.

Scrrenshot 119
So, I think that this cookie can be used to apply settings in Embeds too.

@FireMasterK
Copy link
Member

Piped doesn't use cookies, so it's likely some other application that created it.

@ghost
Copy link
Author

ghost commented Nov 11, 2021

Yes, as you said Piped doesn't use cookies but I think that the embeds could use the cookies if we saved them for Preferences.

@ghost
Copy link
Author

ghost commented Nov 11, 2021

Okay, Completely erase the above what I said, I have an Idea, What about having an Options/Preferences page in Piped Extension, Which will apply the Settings to the embeds. So, No connection need to be made between the Site and Extension. I think this could work.

As in Firefox, it uses dFPI (dynamic First Party Isolation) which might might interfere and might make an issue.

In short, Settings in Site copied to Extensions, which will apply those to the embeds replaced.

What do you think ?

@ghost ghost changed the title Sync Settings in Extension from Site Settings in Site ported to Extension Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant