From f44060f8fcdfa9a21bb63476cf2758d497a053b9 Mon Sep 17 00:00:00 2001 From: Sylvain BERTRAND Date: Tue, 24 Oct 2023 18:13:39 +0000 Subject: [PATCH] ELF Relocatable: make undefined global symbol STT_NOTYPE If undefined global symbols in ELF Relocatable files are not of type STT_NOTYPE, it will confuse binutils bfd and corrupt product files. --- tccelf.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tccelf.c b/tccelf.c index 2e3d8aca7..6f2fd6a47 100644 --- a/tccelf.c +++ b/tccelf.c @@ -176,6 +176,11 @@ ST_FUNC void tccelf_end_file(TCCState *s1) if (sym->st_shndx == SHN_UNDEF && ELFW(ST_BIND)(sym->st_info) == STB_LOCAL) sym->st_info = ELFW(ST_INFO)(STB_GLOBAL, ELFW(ST_TYPE)(sym->st_info)); + /* An ELF relocatable file should have the types of its undefined global symbol set + to STT_NOTYPE or it will confuse binutils bfd */ + if (s1->output_format == TCC_OUTPUT_FORMAT_ELF && s1->output_type == TCC_OUTPUT_OBJ) + if (sym->st_shndx == SHN_UNDEF && ELFW(ST_BIND)(sym->st_info) == STB_GLOBAL) + sym->st_info = ELFW(ST_INFO)(STB_GLOBAL, ELFW(ST_TYPE)(STT_NOTYPE)); tr[i] = set_elf_sym(s, sym->st_value, sym->st_size, sym->st_info, sym->st_other, sym->st_shndx, (char*)s->link->data + sym->st_name); }