Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set defines through environment variables #244

Open
idleberg opened this issue Aug 27, 2022 · 1 comment
Open

Set defines through environment variables #244

idleberg opened this issue Aug 27, 2022 · 1 comment

Comments

@idleberg
Copy link

idleberg commented Aug 27, 2022

Most of the times, I'm using WordPress as provided by the official Docker image. In all other cases, I prefer Roots Bedrock. Both have in common, that they're configured by environment variables. That's why I was wondering if you are open to supporting them to configure your plugin.

Example

defined('JWT_AUTH_SECRET_KEY') ? JWT_AUTH_SECRET_KEY : $_ENV["JWT_AUTH_SECRET_KEY"] ?? false;
defined('JWT_AUTH_CORS_ENABLE') ? JWT_AUTH_CORS_ENABLE : $_ENV["JWT_AUTH_CORS_ENABLE"] ?? false;
@Tmeister
Copy link
Owner

Tmeister commented Oct 7, 2022

Hi,

I think just a handful of people use that configuration but if you created a PR I can consider adding it.

Best,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants