Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NoDist in favour of fix. #760

Open
yebai opened this issue Dec 19, 2024 · 0 comments
Open

Remove NoDist in favour of fix. #760

yebai opened this issue Dec 19, 2024 · 0 comments

Comments

@yebai
Copy link
Member

yebai commented Dec 19, 2024

struct NoDist{variate,support,Td<:Distribution{variate,support}} <:
Distribution{variate,support}
dist::Td
end

can be removed without regression now that we have fix(model, (var=...)). The semantics of NoDist and fix are identical, while fix is more compositional and avoids hardcoding fixed variable information in model specification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant