Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoogleVisionCache shall not store vision analysis result when result has had an error #959

Open
mklaehn opened this issue Nov 9, 2019 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@mklaehn
Copy link
Contributor

mklaehn commented Nov 9, 2019

Describe the bug
VisionAnalysisResult must never be store the ImageContentAnalysis in case the result contained an error. This may happen when Gloud Vision API eroors on loading the imageURL for example.

Should a processing error be cached then successive runs of the analysis will get the failed result from the cache instead of retriggering the request and getting a hopefully succesful request result.

Expected behavior
A failed image analysis result is either not stored in cache or should it be, then it will be rerequested upon the next retrieval of the analysis from the cache.

@mklaehn mklaehn added the bug Something isn't working label Nov 9, 2019
@mklaehn mklaehn self-assigned this Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant