[TT-13440] Multi-value response headers lost after sync with coprocess middleware

[sebkehr]

Do you want to request a feature or report a bug?

I like to report a (possible) bug.

What is the current behavior?

Currently, when synchronizing single- and multi-valued header representations of coprocess-based middleware responses (see function syncHeadersAndMultiValueHeaders in gateway/coprocess.go#L608) the list of values for any multi-valued header is replaced by a singleton list (see gateway/coprocess.go#L616) containing only the value given by its single-value representation. Thus, all multi-value header values but the first are effectively dropped. Moreover, as synchronization of multi-value headers is triggered on any change of the map containing single-value representations (see gateway/coprocess.go#L586) all multi-value header values (except the first) are dropped even if those were not even modified.

What is the expected behavior?

Header synchronization should replace only the first value and retain possibly remaining values of multi-valued headers.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

When employing a coprocess (response) middleware to modify the Location header of a redirect response from upstream which also contains multiple Set-Cookie headers only the first Set-Cookie header will be contained in the effective response.

Which versions of Tyk affected by this issue? Did this work in previous versions of Tyk?

We discovered the behaviour with Tyk 5.3. But the mentioned code did not change since then.

[andyo-tyk]

Hi @sebkehr,
Thanks for raising this - and for the proposed fix.
We will take a look and get back to you once we've reviewed the issue and your PR.

[sebkehr]

Hi @andyo-tyk,
thanks for looking into it.
Please let me know if you have further questions on the issue and/or my PR.