Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

help message problems when partial values are given #61

Open
KrisThielemans opened this issue Jun 11, 2020 · 2 comments
Open

help message problems when partial values are given #61

KrisThielemans opened this issue Jun 11, 2020 · 2 comments
Assignees
Labels
bug upstream_problem Problem that we cannot fix as it sits in a dependency wontfix

Comments

@KrisThielemans
Copy link
Collaborator

KrisThielemans commented Jun 11, 2020

If a command line is incomplete, the executables print a usage message. However, confusingly it says that current values are default. Example

$ pvc_rl -x 10 -y 16 -z 9 --iter 1  blur.nii.gz 

Option outputfile is required but not defined
 Command tags: 
   -x < X > 
      = The full-width at half maximum in mm along x-axis
        With: X (Default = 10)
   -y < Y > 
      = The full-width at half maximum in mm along y-axis
        With: Y (Default = 16)
   -z < Z > 
      = The full-width at half maximum in mm along z-axis
        With: Z (Default = 9)
   [ -i --iter [ Val ] ]
      = Number of iterations
        With: Val (Default = 1)
   [ -d --debug ]
      = Prints debug information
 Command fields: 
   < petfile > 
      = PET filename
        With: petfile (Default = blur.nii.gz)
   < outputfile > 
      = output filename

Actually the default number of iterations is 10, and x,y,z and petfile do not have defaults (i.e. are required)

@KrisThielemans KrisThielemans self-assigned this Jun 11, 2020
@bathomas
Copy link
Collaborator

I seem to remember this being a feature of ITK's metaCommand. In an ideal world, I think the command line parsing should either be replaced or custom written. I've never really liked the images without switches but have been reluctant to change as it would break the the nipype wrapper.

@KrisThielemans
Copy link
Collaborator Author

ok. We have control over this, so cannot fix this either. We will therefore leave this issue open as a warning for others.

@KrisThielemans KrisThielemans added the upstream_problem Problem that we cannot fix as it sits in a dependency label Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug upstream_problem Problem that we cannot fix as it sits in a dependency wontfix
Projects
None yet
Development

No branches or pull requests

2 participants