Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omnibus comment changes #1105

Merged
merged 12 commits into from
Nov 3, 2023
Merged

omnibus comment changes #1105

merged 12 commits into from
Nov 3, 2023

Conversation

EvaJanouskova
Copy link
Collaborator

Fixed a few typos I came across.

Updated/moved some comments.

@EvaJanouskova EvaJanouskova mentioned this pull request Sep 12, 2023
20 tasks
@tbhallett
Copy link
Collaborator

Thanks for this @EvaJanouskova -- I'll leave this open a little longer in case other small things need to be changed.

@EvaJanouskova
Copy link
Collaborator Author

@tbhallett, The description at the top of hsi_generic_first_appts.py seems outdated, doesn't it?

@tbhallett
Copy link
Collaborator

@tbhallett, The description at the top of hsi_generic_first_appts.py seems outdated, doesn't it?

Yes it is a bit, you’re right. It should explain that those appointments can run at different levels.

EvaJanouskova added a commit that referenced this pull request Sep 20, 2023
EvaJanouskova added a commit that referenced this pull request Sep 29, 2023
EvaJanouskova added a commit that referenced this pull request Sep 29, 2023
EvaJanouskova added a commit that referenced this pull request Sep 29, 2023
@EvaJanouskova EvaJanouskova force-pushed the EvaJ/omnibus_comment_changes branch 4 times, most recently from 8d8ec23 to 522985d Compare September 29, 2023 22:58
EvaJanouskova added a commit that referenced this pull request Oct 9, 2023
EvaJanouskova added a commit that referenced this pull request Oct 11, 2023
EvaJanouskova added a commit that referenced this pull request Oct 11, 2023
EvaJanouskova added a commit that referenced this pull request Oct 11, 2023
EvaJanouskova added a commit that referenced this pull request Oct 11, 2023
EvaJanouskova added a commit that referenced this pull request Oct 24, 2023
@EvaJanouskova EvaJanouskova force-pushed the EvaJ/omnibus_comment_changes branch from 9b7374a to 0658305 Compare October 25, 2023 21:15
@tbhallett
Copy link
Collaborator

thanks for all these @EvaJanouskova --- is it ready to go in?

@EvaJanouskova
Copy link
Collaborator Author

thanks for all these @EvaJanouskova --- is it ready to go in?

There will always be smt, but it is all I have right now, so I think it can go in.

@tbhallett tbhallett merged commit 7c152da into master Nov 3, 2023
55 checks passed
@EvaJanouskova EvaJanouskova deleted the EvaJ/omnibus_comment_changes branch November 3, 2023 12:30
EvaJanouskova added a commit that referenced this pull request Nov 14, 2023
EvaJanouskova added a commit that referenced this pull request Nov 14, 2023
EvaJanouskova added a commit that referenced this pull request Nov 14, 2023
EvaJanouskova added a commit that referenced this pull request Nov 15, 2023
EvaJanouskova added a commit that referenced this pull request Nov 15, 2023
EvaJanouskova added a commit that referenced this pull request Nov 20, 2023
EvaJanouskova added a commit that referenced this pull request Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants