-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up build script and cmake #101
Conversation
with test disabled. @srsuryadev I added the latest stable version (73d4d5e8d6d449fc8663765a42aa8aeeee844489)
I think earlier there was a problem that the hustle code had some parts (especially some wrappers that were written around some arrow functions) which required a particular version of the arrow to work correctly. |
Seems like we're not using any modified arrow? Then shall we just make arrow a part of the CMake dependency? |
Yes, it seems things are fine! If with the latest arrow version there's no issue with the tests, then we should be good! |
We did download arrow using a custom script to be able to control the version of arrow. Can we control the arrow version when we make arrow part of the cmake toolchain? --even if the answer is no I like the cleaner flow that making arrow part of the cmake toolchain gives us One question you might want to answer between the 3 of you (@srsuryadev, @GindaChen, @mprammer2) is if we still depend on arrow methods that are not part of their external api which might change from version to version. -- if yes we might want to keep track of them and anticipate possible changes |
The build time is just so long and a test failed...
Yes - and we can still do custom repo to host our arrow in CMake.
I don't know... eventually maybe not, but we may want to discuss this a bit further. Adding another abstraction on compute, not the type system, could be beneficial; but the whether the type system should depend on that is a big question. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nits
Partially fixed #100. This PR is to test if Ubuntu20 can compile Hustle in CircleCI.
Changes
Bump up CircleCI instance to Ubuntu20.Defer this until we can optimize the build container down to 15 mins (now is > 30mins). We already build on Cloudlab.Add a CircleCI test on Ubuntu20 build with CPP20.install_requirements_cpp20.sh
to install Hustle with CPP20 in Ubuntu 16, 18 and 20.04.Questions / Discussion