Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up build script and cmake #101

Merged
merged 13 commits into from
Mar 14, 2021
Merged

Conversation

GindaChen
Copy link
Member

@GindaChen GindaChen commented Mar 13, 2021

Partially fixed #100. This PR is to test if Ubuntu20 can compile Hustle in CircleCI.

Changes

  • Include google benchmark as part of the CMake tool chain. This avoid using the brew installed google benchmark if they are compiled on clang.
  • Bump up CircleCI instance to Ubuntu20. Defer this until we can optimize the build container down to 15 mins (now is > 30mins). We already build on Cloudlab.
  • Add a CircleCI test on Ubuntu20 build with CPP20.
  • Add install_requirements_cpp20.sh to install Hustle with CPP20 in Ubuntu 16, 18 and 20.04.

Questions / Discussion

  1. @pateljm - Shall we bump Ubuntu to 20?
  2. @srsuryadev @johnchronis - Shall we make arrow part of the CMake tool chain? What was the difficulty doing so in the past?

@srsuryadev
Copy link
Contributor

I think earlier there was a problem that the hustle code had some parts (especially some wrappers that were written around some arrow functions) which required a particular version of the arrow to work correctly.

@GindaChen
Copy link
Member Author

Seems like we're not using any modified arrow? Then shall we just make arrow a part of the CMake dependency?

@srsuryadev
Copy link
Contributor

Yes, it seems things are fine! If with the latest arrow version there's no issue with the tests, then we should be good!

@johnchronis
Copy link
Collaborator

We did download arrow using a custom script to be able to control the version of arrow.
@srsuryadev is right, this choice was a result of an incident where arrow updated some internal method we depended on.

Can we control the arrow version when we make arrow part of the cmake toolchain? --even if the answer is no I like the cleaner flow that making arrow part of the cmake toolchain gives us

One question you might want to answer between the 3 of you (@srsuryadev, @GindaChen, @mprammer2) is if we still depend on arrow methods that are not part of their external api which might change from version to version. -- if yes we might want to keep track of them and anticipate possible changes

@GindaChen GindaChen marked this pull request as ready for review March 14, 2021 01:30
@GindaChen
Copy link
Member Author

Can we control the arrow version when we make arrow part of the cmake toolchain?

Yes - and we can still do custom repo to host our arrow in CMake.

Shall we depend on arrow API?

I don't know... eventually maybe not, but we may want to discuss this a bit further. Adding another abstraction on compute, not the type system, could be beneficial; but the whether the type system should depend on that is a big question.

Copy link
Contributor

@srsuryadev srsuryadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits

.circleci/config.yml Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
Brewfile Outdated Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
@GindaChen GindaChen merged commit de930e9 into master Mar 14, 2021
@GindaChen GindaChen deleted the clean-up-build-script-and-cmake branch March 14, 2021 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up build script for C++17/20
3 participants