Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HashAggregate #58

Open
3 of 8 tasks
GindaChen opened this issue Nov 5, 2020 · 1 comment
Open
3 of 8 tasks

HashAggregate #58

GindaChen opened this issue Nov 5, 2020 · 1 comment
Assignees

Comments

@GindaChen
Copy link
Member

GindaChen commented Nov 5, 2020

This issue extends #57 to make sure HashAggregate delivers the following:

  • Replace the std::unordered_map hash tables to phmap (ideally) for better performance.
  • Add a toggle in AggregateStrategy to flip between HashAggregate and Aggregate. We can also introduce this toggle in ssb_workload.cc and ssb_workload_lip.cc to compare the performance.
  • Handle hash conflict more elegantly. (Using phmap and custom hash_combine function can eliminate the problem).
  • Design an abstraction over the hash table, and remove some redundant type-checking codes of the arrow arrays.
  • Refactor arrow_compute_wrapper and add some helpers to optimize the array construction.
  • Eliminate most data copy between std:: and arrow::.
  • No memory leak. Free all memory after the Finish().
  • Make code readable: use less auto
@GindaChen
Copy link
Member Author

See #67 for primer benchmark result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant