-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discrepancy between Wiki and Config #34
Comments
Ooh! I was right! SmoothBoot is actually programmed wrong, and the wiki is lying! I'm going to assume that the Hang tight. |
I think the wiki is very outdated by this point. Right now the default values of the mod config is |
Actually, I think On my 8-thread CPU, a 7-thread game runs alright. But so does a 4-thread Minecraft. On a 24-thread CPU, does the game really need 23 threads? No. It'll be more than fine with 12. |
And for that matter, we're only specifying the default here. The user still has the ability to change their config if they want more threads. They also still have the ability to install other mods to increase parallelization, such as C2ME, which I use. |
A reasonable limit should be found by testing some currently targeted Minecraft versions to find the sweetspot, where increasing concurrency does not help. Then limit by:
On Windows you can limit the amount of cores the OS boots up with using On Linux there's the maxcpus kernel parameter. And apparently you could power down CPU cores live, though pay attention for them to not start again. For consistency, you should exit background programs and make sure the entire Minecraft instance ends up in the file cache (reading all files in the folder). A mod to ease the testing would be neat, one which logs current time when the main menu is entered. This way you can start MC, come back later and calculate the time from the logs. Waiting with a stopwatch is sooo 20th century! |
I've found a strange discrepancy between what actually showed up in my Smooth Boot config
.json
and what the Smooth Boot wiki says should appear in the.json
. The page of the wiki in question is Configuration ~ Fabric 1.16+.You see, my CPU has 4 cores, but 8 threads thanks to Intel Hyperthreading. (It's a 10th-Gen Intel Core i7.) The page of the wiki linked above states that certain thread counts are supposed to be calculated from your CPU's thread count, but the values I found in my
.json
(which I have not modified) do not match what the wiki suggests should be there. The wiki also states the Thread Priority values that Smooth Boot uses, but once again, the numbers provided by the wiki do not match up with what I found in the.json
.Now, for the Thread Priorities I suspsect the wiki just needs to be updated. The Thread Count discrepancy is more worrying, though. Either the wiki is lying, or the Smooth Boot is calculating the thread count incorrectly.
Here are my findings regarding Thread Count:
.json
Here are my findings regarding Thread Priority:
.json
The text was updated successfully, but these errors were encountered: