Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the rationale for freezing the Solidity version? #260

Open
lilyanB opened this issue Oct 17, 2024 · 2 comments
Open

What is the rationale for freezing the Solidity version? #260

lilyanB opened this issue Oct 17, 2024 · 2 comments

Comments

@lilyanB
Copy link

lilyanB commented Oct 17, 2024

Hello
I've seen that all interfaces have been moved to ^0.8.0 but not contracts. This would make it possible to use them when importing
change this: pragma solidity 0.8.17
to this: pragma solidity ^0.8.17;
I can do it if needed

@hensha256
Copy link
Collaborator

The core contract is frozen in version for security reasons - that is the version of solidity that it is audited for. However the interfaces are made to be variable versions so that you can integrate with Permit2 in your codebase. Why is it you need to import Permit2.sol and not just use IPermit2.sol?

@lilyanB
Copy link
Author

lilyanB commented Oct 17, 2024

We need to use Permit2.sol for testing purposes. Right now, we have to fork ETH mainnet to have the contract already deployed so we can use only IPermit2.sol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants