Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AnglePickerControl: no help property, no margin bottom, outdated doc #68575

Open
slaFFik opened this issue Jan 9, 2025 · 1 comment
Open

AnglePickerControl: no help property, no margin bottom, outdated doc #68575

slaFFik opened this issue Jan 9, 2025 · 1 comment
Labels
[Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@slaFFik
Copy link

slaFFik commented Jan 9, 2025 •
edited
Loading

I tried using the AnglePickerControl component.

What I noticed:

  1. the storybook doesn't mention className property, which it supports.
  2. the dev doc doesn't mention the className property, which it supports.
  3. component supports label but does not support help for some reason.
  4. the component does not have margin-bottom like RangeControl or others.

The workaround to 3. and 4. is to wrap it in BaseControl, set BaseControl[label] and BaseControl[help] properties. And then you must set AnglePickerControl[label] property to an empty string to remove duplicated labels. Quite ugly.
@slaFFik slaFFik added the [Type] Enhancement A suggestion for improvement. label Jan 9, 2025
@Rishit30G Rishit30G mentioned this issue Jan 10, 2025
Open
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 10, 2025
@Rishit30G
Copy link
Contributor

Hey @slaFFik,
Thanks for bringing up the issue,
I have raised a PR for point 1 and 2 ( #68584 )
For 3 and 4, I believe we would be needing design feedback 🙇🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@slaFFik @Rishit30G