Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download language data: remove or make package? #30

Open
brenthuisman opened this issue Feb 15, 2024 · 1 comment
Open

Download language data: remove or make package? #30

brenthuisman opened this issue Feb 15, 2024 · 1 comment

Comments

@brenthuisman
Copy link
Contributor

Currently the official Wuggy language files aren't provided with Wuggy, but require downloading through a series of prompts. These files are (at least before the changes of 3 days ago) put in the library installation directory, which is in many environments not directly writable by users, and makes it hard to properly version and manage the data (you always have to setup an env and then go through the prompts).

I imagine this is mainly motivated by saving disk space. ~89MB is a lot, sure, but not that much either. I therefore propose some solutions:

  1. Add the language files (back) to a default installation of Wuggy.
    • Python has built-in file decompression libraries, so the size can be reduced. Gzip of wuggy_language_plugin_data is 21.6MB, bzip brings it down to 19.0MB.
  2. Make them separate Python packages, so the can be added to the dependencies of other packages. Could be a single package (all languages) or per language.
  3. Remove the notion of 'installed' 'official' languages, and force users to provide their own language library, and assume these will be in arbitrary locations of the user's filesystem (maybe this already works well, haven't checked actually :))
@Zenulous
Copy link
Collaborator

I like the idea of having the official plugin language data as one separate package. This way the default Wuggy package remains light and minimalistic. So that would be option 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants