mr: Handle upon 'or' case more properly #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When given 3 or more 'or' events in the 'upon' clause, the regular_condition_unexp_pt splits (a|b|c) into ((a|b)|c), surrounded by brackets. This was not handled properly, the result contained e.g. (a with bracket. This shows that the current split behaviour is not sufficient for cases where all of FRET allowed features is correctly transformed. While sufficient for simpler cases and the features we used, there is still work to do for a proper transformation case. Signed-off-by: Stefan Kraus <[email protected]>
schlotter
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When given 3 or more 'or' events in the 'upon' clause, the regular_condition_unexp_pt splits (a|b|c) into ((a|b)|c), surrounded by brackets. This was not handled properly, the result contained e.g. (a with bracket.
This shows that the current split behaviour is not sufficient for cases where all of FRET allowed features is correctly transformed. While sufficient for simpler cases and the features we used, there is still work to do for a proper transformation case.