diff --git a/pkg/sources/reconciler/azservicebussource/adapter.go b/pkg/sources/reconciler/azservicebussource/adapter.go index 060828d..6f45cbc 100644 --- a/pkg/sources/reconciler/azservicebussource/adapter.go +++ b/pkg/sources/reconciler/azservicebussource/adapter.go @@ -49,7 +49,6 @@ func MakeAppEnv(o *v1alpha1.AzureServiceBusSource) []corev1.EnvVar { } var appEnvs []corev1.EnvVar - //TODO should this be here? if sasAuth := o.Spec.Auth.SASToken; sasAuth != nil { appEnvs = common.MaybeAppendValueFromEnvVar(appEnvs, common.EnvServiceBusKeyName, sasAuth.KeyName) appEnvs = common.MaybeAppendValueFromEnvVar(appEnvs, common.EnvServiceBusKeyValue, sasAuth.KeyValue) diff --git a/pkg/sources/reconciler/azservicebussource/subscription.go b/pkg/sources/reconciler/azservicebussource/subscription.go index 4eee2f7..ffbed66 100644 --- a/pkg/sources/reconciler/azservicebussource/subscription.go +++ b/pkg/sources/reconciler/azservicebussource/subscription.go @@ -33,6 +33,8 @@ const crudTimeout = time.Second * 15 // Required permissions: // - Microsoft.ServiceBus/namespaces/topics/subscriptions/read // - Microsoft.ServiceBus/namespaces/topics/subscriptions/write +// +// nolint:gocyclo func EnsureSubscription(ctx context.Context, cli servicebustopics.SubscriptionsClient) error { if skip.Skip(ctx) { return nil @@ -174,6 +176,7 @@ func recursErrMsg(errMsg string, err error) string { errMsg += ": " } + // nolint:errorlint switch tErr := err.(type) { case autorest.DetailedError: return recursErrMsg(errMsg+tErr.Message, tErr.Original) diff --git a/pkg/sources/reconciler/azservicebustopicsource/subscription.go b/pkg/sources/reconciler/azservicebustopicsource/subscription.go index 3528744..d35a4bd 100644 --- a/pkg/sources/reconciler/azservicebustopicsource/subscription.go +++ b/pkg/sources/reconciler/azservicebustopicsource/subscription.go @@ -33,6 +33,8 @@ const crudTimeout = time.Second * 15 // Required permissions: // - Microsoft.ServiceBus/namespaces/topics/subscriptions/read // - Microsoft.ServiceBus/namespaces/topics/subscriptions/write +// +// nolint:gocyclo func EnsureSubscription(ctx context.Context, cli servicebustopics.SubscriptionsClient) error { if skip.Skip(ctx) { return nil @@ -174,6 +176,7 @@ func recursErrMsg(errMsg string, err error) string { errMsg += ": " } + // nolint:errorlint switch tErr := err.(type) { case autorest.DetailedError: return recursErrMsg(errMsg+tErr.Message, tErr.Original)