Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Behavior: Should return NA when length not a multiple of 3 #352

Open
mikegilchrist opened this issue Jul 14, 2020 · 1 comment
Open

Comments

@mikegilchrist
Copy link
Contributor

Right now we get a warning if a gene isn't a multiple of 3 nucleotides.
However, a phi value and other stats returned for these genes.
Instead, ROC should return "NA"

@acope3
Copy link
Owner

acope3 commented Nov 5, 2021

Alternatively, we shouldn't even store these in the genome object, so nothing will be output. Also could put this on the user, i.e. make clear in the documentation that the user is responsible for inputing appropriate CDS sequences (although we will tell them which sequences are problematic).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants