Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openj9 nightly from artifactory openjdk tests is mistakenly running against extra eclipse ( eclispe adoptium) problemlist #656

Open
sophia-guo opened this issue Jan 8, 2025 · 1 comment

Comments

@sophia-guo
Copy link
Contributor

sophia-guo commented Jan 8, 2025

Grinder https://ci.adoptium.net/view/Test_grinder/job/Grinder/12189/console

15:22:53  -exclude:"/home/jenkins/workspace/Grinder/aqa-tests/TKG/../openjdk/openjdk-jdk/test/jdk/ProblemList.txt" \
15:22:53  -exclude:"/home/jenkins/workspace/Grinder/aqa-tests/TKG/../../jvmtest/openjdk/excludes/ProblemList_openjdk17-openj9.txt" \
15:22:53   \
15:22:53  -exclude:"/home/jenkins/workspace/Grinder/aqa-tests/TKG/../openjdk/excludes/vendors/eclipse/ProblemList_openjdk17.txt" \
15:22:53  "/home/jenkins/workspace/Grinder/aqa-tests/TKG/../openjdk/openjdk-jdk/test/jdk:jdk_nio"; \

https://github.com/adoptium/TKG/blob/master/src/org/openj9/envInfo/JavaInfo.java#L173-L174 set vendor=eclispe for both java.vendor=Eclispe Adoptium(temurin) and java.vendor=Eclispe Openj9 (openj9). aqa-tests/openjdk use vendor=eclipse https://github.com/adoptium/aqa-tests/tree/master/openjdk/excludes/vendors/eclipse https://github.com/adoptium/aqa-tests/blob/master/openjdk/openjdk.mk#L244 for adoptium specific issues.

java.vendor=Eclispe Adoptium(temurin) and java.vendor=Eclispe Openj9 (openj9) need to be differentiated.

Possible solutions is redefining vendor value for example:
java.vendor=Eclispe Adoptium(temurin) --> adoptium, or temurin, or eclipseadoptium
java.vendor=Eclispe Openj9 (openj9) --> openj9, or eclispeopenj9 or ibm ( if using ibm, openj9 and semu can still be differentiated by impl)

The vendor value redefinition might affect playlist.xml. If playlist.xml is using eclipse it might need to update.

@sophia-guo
Copy link
Contributor Author

Related adoptium/aqa-tests#5835

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant