Skip to content
This repository has been archived by the owner on Dec 22, 2022. It is now read-only.

Redundant pip install invocations in jenkins tests? #53

Open
nbren12 opened this issue Jan 28, 2021 · 0 comments
Open

Redundant pip install invocations in jenkins tests? #53

nbren12 opened this issue Jan 28, 2021 · 0 comments

Comments

@nbren12
Copy link
Contributor

nbren12 commented Jan 28, 2021

The requirements are installed here:
https://github.com/VulcanClimateModeling/fv3gfs-util/blob/c98b077c52759bee589f30062d62149098de3088/.jenkins/actions/test.sh#L71-L71

and here:
https://github.com/VulcanClimateModeling/fv3gfs-util/blob/d8b37264a26becf763fe7f5988a1190c54d2c9a7/.jenkins/jenkins.sh#L53-L56

It's not really clear what the resulting version of the requirements would be installed. Once #50 is merged, it might be cleaner to use tox for the jenkins builds as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant