Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setProgress results in a crash, when input data is greater than 32 bit #19

Open
Tienisto opened this issue Jul 16, 2024 · 0 comments
Open

setProgress results in a crash, when input data is greater than 32 bit #19

Tienisto opened this issue Jul 16, 2024 · 0 comments

Comments

@Tienisto
Copy link

Tienisto commented Jul 16, 2024 •
edited
Loading

When calling setProgress with a large number that is valid in Dart code (because Dart int is always 64 bit), the application will crash.

Reproduction:

await WindowsTaskbar.setProgress(0, 2147483647 + 1);

Relevant code line:

windows_taskbar/windows/windows_taskbar.cc

Line 42 in f2f28ea

bool WindowsTaskbar::SetProgress(int32_t completed, int32_t total) {

Either scale down the input data on Dart side, or on native side. For example, I've scaled it down on Dart side: localsend/localsend#1512
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tienisto