Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double check process group is gone after lead process exited. #13

Open
andrewchambers opened this issue Apr 2, 2019 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@andrewchambers
Copy link
Owner

andrewchambers commented Apr 2, 2019

Once a supervised process is shutdown and exited, we could make extra sure the process group we created for it is fully exited, if not, we can send a sigterm or sigkill to the remaining processes.

An alternative is to not reap the dead child pid while waiting for it, this way we can be sure there is no race condition when sending a final term/kill to the group before waiting the pid.

This should be a rare case, that requires misbehaving user programs, but it is nice to have, since we aim for fault tolerance.

@andrewchambers andrewchambers added the enhancement New feature or request label Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant