You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Line 210 and 211 in sortphotos.py:
increment.decode('utf-8') encountered issue because it truncated bytes in size = 4096.
encoding 'utf-8' can have various bytes (1 to 4), thus increment = os.read(fd, 4096) may cut through a character. I found the issue while sorting through 80,000 photos, many of which had Chinese characters as names. In my case, because decode('utf-8') was done on increment, the issue occurred.
I think the decoding should be done on the full output: output += increment to be done first and then output.decode('utf-8') to be done afterward. I modify the source code and tested it. It worked.
Thank you for your effort to make such a great tool!
The text was updated successfully, but these errors were encountered:
Line 210 and 211 in sortphotos.py:
increment.decode('utf-8') encountered issue because it truncated bytes in size = 4096.
encoding 'utf-8' can have various bytes (1 to 4), thus increment = os.read(fd, 4096) may cut through a character. I found the issue while sorting through 80,000 photos, many of which had Chinese characters as names. In my case, because decode('utf-8') was done on increment, the issue occurred.
I think the decoding should be done on the full output: output += increment to be done first and then output.decode('utf-8') to be done afterward. I modify the source code and tested it. It worked.
Thank you for your effort to make such a great tool!
The text was updated successfully, but these errors were encountered: