-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple Link Preview Containers on One Page #60
Comments
Hi @AnthonyNahas
Now if we put a link inside the first text area, it renders the preview in both containers Ideally, it would be nice to be able to link input fields to specific containers so multiple instances can be used in the same component. Similar to how Angular Datepicker is implemented |
I see! I will really appreciate a PR from you !! |
Any news on this? It would be really nice. |
Sorry I had no time to look into this. Have a quite lengthy backlog on my hands and this is towards the bottom. I am not a front end dev so I need to educate myself in type script a little bit before doing this. If anybody wants to pick it up feel free. From what I remember during my initial pass, this behavior is coming from the fact that the injected service is a singleton. An easy, obvious work around is to, instead of having a shared service, to init one per component but I think it is bad practice to do so. I think the best way to do this will be to pass the service some sort of identifier and keep the links in a map instead of a list. Datepicker, I believe achieves this through ViewChilds but as I said, I need to dig into datepicker to see exactly how they do it and the 30 files in the repo doesn't make it much easier. I need to block a good chunk of time to dig into that. Will try to get to this Q1 2020 hopefully. |
no problem thank u |
how to set linkpreview on page load |
Any news on this? |
PR are welcome guys |
any solution for this? |
Bug Report or Feature Request (mark with an
x
)OS and Version?
Versions
Repro steps
The log given by the failure
Desired functionality
Mention any other details that might be useful
The text was updated successfully, but these errors were encountered: