Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TemperatureChangeRate conversion wrong way around #1435

Closed
vierlijner opened this issue Nov 26, 2024 · 4 comments
Closed

TemperatureChangeRate conversion wrong way around #1435

vierlijner opened this issue Nov 26, 2024 · 4 comments
Labels

Comments

@vierlijner
Copy link

In file TemperatureChangeRate I think they put the from and to formulas the wrong way around. From minutes to sec is * 60 instead of / 60.

@vierlijner vierlijner added the bug label Nov 26, 2024
@vierlijner
Copy link
Author

I saw this because of commit #1429

@angularsen
Copy link
Owner

angularsen commented Nov 29, 2024

No I believe it is correct, but you are perhaps confused by the "inversion" of a temperature unit over time?

DegreeCelsiusPerMinute is simpler to look at, and "FromBaseToUnitFunc": "{x} * 60", does get you from base unit DegreeCelsiusPerSecond to DegreeCelsiusPerMinute. E.g. (1 DegreeCelsiusPerSecond) * 60 => 60 DegreeCelsiusPerMinute

We also verify the direction by having both roundtrip tests and oneway tests, and double checking with Google confirms it.

image

image

image

image

@vierlijner
Copy link
Author

O yes I see, I forgot that it's divide by time, so you have to invert the operation. Thank and sorry, I had to verify it first. (but in my head it was so obvious, but to fast).

@angularsen
Copy link
Owner

No problem 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants