Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow that runs jacocoTestReport on AnkiDroid PR against Anki-Android-Backend PR #232

Open
mikehardy opened this issue Jun 28, 2022 · 5 comments
Labels

Comments

@mikehardy
Copy link
Member

There was an issue that only turned up in Anki-Android (this repo) CI after merging + releasing an Anki-Android-Backend PR and it would be nice to have a workflow that allowed a PR here that was dependent on a PR there to run our CI targets on the PR here against the result of the backend build there

Just some brainstorming:

  • I believe it is possible to have some workflows be callable and provide them arguments, perhaps we could keep the CI workflows fully separate in their repos and just call them - that is have a backend workflow we can call on a specific git commit hash and it will provide a local library we can test?
  • maybe in the test workflows here, if there is a local.properties parse it and see if it is local_backend=true, if it is pull a new property that is a git reference (so you can use a branch name) and if it is, then call out to a backend workflow on that hash to build a local rsdroid ?

That would require a final commit in a PR here after launch+release to remove the local.properties but it would still be incremental improvement

...or something

@mikehardy mikehardy added the Dev label Jun 28, 2022
mikehardy referenced this issue in ankidroid/Anki-Android Jun 28, 2022
espresso-contrib has a transitive dependency on an old protobuf library
version, which conflicts with the newer version we're including
@david-allison
Copy link
Member

Iw we use workflow_dispatch + input: string, we can avoid having the commit ref in the local.properties.

Upsides:

  • No need to add in 'test' commits

Downsides:

  • Reapplying workflows may take a little longer

@mikehardy
Copy link
Member Author

I think a requirement is that it has to be fully automated at least within context of a PR, we can't be fishing out the right string to input, and a test commit while waiting until the real version comes out isn't the worst thing - better than manual workflow runs IMHO

@github-actions
Copy link

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

@mikehardy
Copy link
Member Author

I think this has to be in Anki-Android-Backend now that I think about it. Building the backend is a really non-trivial endeavour and it's all set up there. The workflow should pull Anki-Android after the jars are built and run AnkiDroid test / androidTest against the freshly-built artifacts

@mikehardy mikehardy transferred this issue from ankidroid/Anki-Android Aug 27, 2022
@mikehardy mikehardy changed the title Add workflow here or Anki-Android-Backend that runs jacocoTestReport on AnkiDroid PR against Anki-Android-Backend PR Add workflow that runs jacocoTestReport on AnkiDroid PR against Anki-Android-Backend PR Aug 27, 2022
@dae
Copy link
Contributor

dae commented Oct 28, 2023

I feel like this would challenging to implement, as long as the two repos are separate. We get 90% there already by using ./build.sh and testing locally, so perhaps that's enough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants