Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove most pyfury pure python serializers, use pure cython only #1957

Open
chaokunyang opened this issue Nov 24, 2024 · 0 comments
Open

Remove most pyfury pure python serializers, use pure cython only #1957

chaokunyang opened this issue Nov 24, 2024 · 0 comments

Comments

@chaokunyang
Copy link
Collaborator

Feature Request

Remove pyfury python implementation, use pure cython only

Is your feature request related to a problem? Please describe

Currently pufury has two implementation for object graph serialization:

  • pure python:
    • python/pyfury/_serializer.py
    • python/pyfury/_fury.py
  • cython based:
    • python/pyfury/_serialization.pyx

Pure python version is easy for debugging, especially for debugging complex object graph serialization, since cython code is not easy to debug.

But the code for both are very similar, thus incurred a big maintain overhead.

Describe the solution you'd like

Remove most pure python serializer, only reserve serializer dispatch framework, and keep it as the most simple way, the performance is not a requirement

Describe alternatives you've considered

No response

Additional context

No response

@chaokunyang chaokunyang changed the title [RFC] Remove pyfury python implementation, use pure cython only [RFC] Remove most pyfury pure python serializers, use pure cython only Nov 24, 2024
@chaokunyang chaokunyang changed the title [RFC] Remove most pyfury pure python serializers, use pure cython only Remove most pyfury pure python serializers, use pure cython only Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant