Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fury Rust compile error #1961

Open
1 of 2 tasks
chaokunyang opened this issue Nov 30, 2024 · 0 comments
Open
1 of 2 tasks

Fury Rust compile error #1961

chaokunyang opened this issue Nov 30, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@chaokunyang
Copy link
Collaborator

chaokunyang commented Nov 30, 2024

Search before asking

  • I had searched in the issues and found no similar issues.

Version

main

Component(s)

Rust

Minimal reproduce step

cargo test

What did you expect to see?

compile success

What did you see instead?

error: elided lifetime has a name
  --> fury-core/src/row/writer.rs:38:10
   |
33 | impl<'a> FieldWriterHelper<'a> {
   |      -- lifetime `'a` declared here
...
38 |     ) -> FieldWriterHelper {
   |          ^^^^^^^^^^^^^^^^^ this elided lifetime gets resolved as `'a`
   |
   = note: `-D elided-named-lifetimes` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(elided_named_lifetimes)]`

error: the following explicit lifetimes could be elided: 'a
  --> fury-core/src/row/row.rs:77:6
   |
77 | impl<'a> Row<'a> for bool {
   |      ^^      ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
   = note: `-D clippy::needless-lifetimes` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::needless_lifetimes)]`
help: elide the lifetimes
   |
77 - impl<'a> Row<'a> for bool {
77 + impl Row<'_> for bool {
   |

error: the following explicit lifetimes could be elided: 'a
  --> fury-core/src/row/row.rs:89:6
   |
89 | impl<'a> Row<'a> for NaiveDate {
   |      ^^      ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
   |
89 - impl<'a> Row<'a> for NaiveDate {
89 + impl Row<'_> for NaiveDate {
   |

error: the following explicit lifetimes could be elided: 'a
   --> fury-core/src/row/row.rs:107:6
    |
107 | impl<'a> Row<'a> for NaiveDateTime {
    |      ^^      ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
107 - impl<'a> Row<'a> for NaiveDateTime {
107 + impl Row<'_> for NaiveDateTime {
    |

error: the following explicit lifetimes could be elided: 'a
  --> fury-core/src/row/writer.rs:70:6
   |
70 | impl<'a> StructWriter<'a> {
   |      ^^               ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
   |
70 - impl<'a> StructWriter<'a> {
70 + impl StructWriter<'_> {
   |

error: the following explicit lifetimes could be elided: 'a
   --> fury-core/src/row/writer.rs:108:6
    |
108 | impl<'a> ArrayWriter<'a> {
    |      ^^              ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
108 - impl<'a> ArrayWriter<'a> {
108 + impl ArrayWriter<'_> {
    |

error: the following explicit lifetimes could be elided: 'a
   --> fury-core/src/row/writer.rs:151:6
    |
151 | impl<'a> MapWriter<'a> {
    |      ^^            ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
151 - impl<'a> MapWriter<'a> {
151 + impl MapWriter<'_> {
    |

image

Anything Else?

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@chaokunyang chaokunyang added the bug Something isn't working label Nov 30, 2024
chaokunyang pushed a commit that referenced this issue Dec 1, 2024
## What does this PR do?
Fix the lint warnings in issue #1961 which was caused by the upgrade of
clippy.

## Related issues
#1961 

## Does this PR introduce any user-facing change?

## Benchmark
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant