You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The code to merge settings into the django settings machinery is:
difficult to remove/refactor, introduces circular import problems
goes against Django doc guidance to avoid altering settings at runtime
goes against Django doc guidance to avoid module-level queries
difficult to mock when testing, requires custom decorator to wrap the django decorators for overriding settings
Introduces the risk of importing the wrong settings object (vanilla or custom?)
Raises questions about arches application architecture
However, having a friendly user interface for updating a subset of settings is useful!
Suggest in a future version having a friendly user interface for these settings, whether an Arches resource model or not, that is not then merged back into the django settings module.
There are some disadvantages to merging the user-configurable settings (
SystemSettings
) into the Django settings (django.conf.settings
).SEARCH_EXPORT_LIMIT
insettings.py
ignored by whatever in Arches frontend system settings #11697, incorrect docstring onSystemSettings
classHowever, having a friendly user interface for updating a subset of settings is useful!
Suggest in a future version having a friendly user interface for these settings, whether an Arches resource model or not, that is not then merged back into the django settings module.
cc/ @chrabyrd
The text was updated successfully, but these errors were encountered: