Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grab_historical_prices method a little misleading in description #14

Open
Wolfslayer opened this issue Dec 3, 2020 · 0 comments
Open

Comments

@Wolfslayer
Copy link

bar_type {str} -- Defines the bar type, can be one of the following:

        bar_type {str} -- Defines the bar type, can be one of the following:
            `['minute', 'week', 'month', 'year']` (default: {'minute'})

This is a little misleading, if I follow through to your TDClient code all the way to the TD Ameritrade documentation, there are two discrepencies:

  1. aside from "minute" the rest should be in the form of "weekly" "monthly" and "yearly"

  2. "daily" is also a valid option for bar width

This method is mostly utilized in your examples for streaming data by the minute so not a huge deal for that use, but I've repurposed some of this for myself for plotting candles out into the months and years hence taking a closer look into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant