Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop changes in CSS and class names #538

Open
LisaScheers opened this issue Nov 23, 2022 · 1 comment
Open

Stop changes in CSS and class names #538

LisaScheers opened this issue Nov 23, 2022 · 1 comment
Assignees
Labels
bug Something isn't working covered This issue or pull request has already been suggested and will be part of the next major release
Milestone

Comments

@LisaScheers
Copy link

my death name is a common CSS value fill

replacing this will mess with most websites

the proposed change to add an option to exclude CSS class names and the content of style tags and style attributes from being replaced.

@arimgibson
Copy link
Owner

Hi @LisaScheers, thanks for the feedback! Sorry to hear; that's definitely frustrating and makes sense that the extension should only be replacing visible text; not classes and styles that you won't actually be reading on the page.

This is implemented and will be released through v2.0.0, which only scans text content for deadname replacement. I don't have a good timeline for that release unfortunately, but I'll leave this issue open until then.

@arimgibson arimgibson added this to the Version 2.0.0 milestone Jun 8, 2023
@arimgibson arimgibson self-assigned this Jun 8, 2023
@arimgibson arimgibson added bug Something isn't working covered This issue or pull request has already been suggested and will be part of the next major release labels Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working covered This issue or pull request has already been suggested and will be part of the next major release
Projects
None yet
Development

No branches or pull requests

2 participants