-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proper PWA support (enable PWA installation) #452
Comments
Thanks for the feedback and the idea! This makes sense -- I'll take a look. I always thought it would be separate app by default, but I think last time I tested it was before the manifest standard existed, so no surprise the behavior is different. @jsk95 let me know if you want to take a look. |
@jsk95 Pls let me know if you still want to finish this or if I should take it. |
Hey @ashmind - glad to hear you're still looking into this issue! I've had the chance to use sharplab.io quite a bit on mobile during the last few weeks, and I gathered more feedbacks to share on that front! Opened two issues for that:
Hope this helps! 😊 |
OK this should work now. The icon might be a bit cropped, but that would be a separate issue. |
Note that I opted for |
Hello, congrats for the project, it's incredibly well done and I've been using it for months, it has become an incredibly valuable tool for me and I appreciate your hard work on it! 😄
I was wondering if it'd be possible to make sharplab.io a proper PWA, so that it could be installed on devices that support the feature (eg. Android devices). Right now trying to add sharplab.io to the home page results in a simple shortcut being added to the home page, and clicking on it simply opens the website in a browser tab. This is the expected behavior for websites that don't properly support the minimum PWA specifications, otherwise the website should be opened in a standalone window (eg. like Twitter on mobile). I've tried both with Chrome and Edge Chromium, same result.
I've run a test on the website using Lighthouse and got this report:
Here's the checklists guide from Google on PWAs.
Looks like simply adding a manifest should fix most of the issues and hopefully that'll be enough to have the app open in a standalone window.
Thanks again for your hard work!
The text was updated successfully, but these errors were encountered: