Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: propagate target_compatible_with to _py_env when creating a … #438

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: propagate target_compatible_with to _py_env when creating a … #438

wants to merge 2 commits into from

Conversation

RoyShulman
Copy link

Hi!
This fixes #437.

This is my first issue so I'm not sure if this is the right thing to do.
Tell me if this is good or you want me to change anything :)

@CLAassistant
Copy link

CLAassistant commented Nov 14, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

mattem
mattem reviewed Nov 19, 2024
View reviewed changes
py/defs.bzl Outdated Show resolved Hide resolved
@mattem
Copy link
Collaborator

mattem commented Nov 19, 2024

Thanks, are you able to sign the CLA?

@RoyShulman
Copy link
Author

Hey! is there anything else you want me to do? or can we merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattem mattem mattem left review comments

@thesayyn thesayyn thesayyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: py_test macro doesn't propagate target_compatible_with to _py_venv when building targets
4 participants
@RoyShulman @CLAassistant @mattem @thesayyn