Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firmware version included in message or new topic #49

Open
icolwell-as opened this issue May 31, 2019 · 3 comments
Open

Firmware version included in message or new topic #49

icolwell-as opened this issue May 31, 2019 · 3 comments
Assignees
@amrutamhaske
Labels
enhancement

Comments

@icolwell-as
Copy link
Member

I think it would be very helpful to have the PACMod firmware version published to an existing topic or to some new topic.
This way a recorded rosbag always has PACMod firmware version already included.
@JWhitleyWork
Copy link

This first requires a change to the DBC (and firmware) to transmit the version. This is underway in astuff/pacmod_dbc#10. Once that issue is implemented, I'll follow up with relevant changes to the driver.

@JWhitleyWork
Copy link

@icolwell-as - This is now available in the DBC and will be published by newer versions of the firmware (see astuff/pacmod_dbc@f785a2c). Would you mind implementing it in the driver?

@icolwell-as
Copy link
Member Author

Sounds good! I might not get to it for a while, but I'm interested to learn more about this driver in the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amrutamhaske amrutamhaske

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JWhitleyWork @amrutamhaske @icolwell-as