Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate bands and constants in SpectralIndex objects #24

Open
maawoo opened this issue Nov 28, 2023 · 1 comment
Open

Separate bands and constants in SpectralIndex objects #24

maawoo opened this issue Nov 28, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@maawoo
Copy link

maawoo commented Nov 28, 2023

Hi @davemlz,

I appreciate the work you have put into Awesome Spectral Indices and this package!

While working on this short guide for my students, I thought that it might be a good idea to separate bands and constants in SpectralIndex objects. Meaning that when someone calls spyndex.indices.EVI.bands, for example, it should not return ['g', 'N', 'R', 'C1', 'C2', 'B', 'L'] but only ['N', 'R', 'B']. The constants could be returned separately with spyndex.indices.EVI.constants.

I think it might otherwise lead to confusion, especially for inexperienced users. In the guide I've mentioned, I tried to clear this up by using list comprehension to separate them.

@davemlz
Copy link
Member

davemlz commented May 18, 2024

This makes a lot of sense!

I will work on this for the future version ;)

@davemlz davemlz self-assigned this May 18, 2024
@davemlz davemlz added the enhancement New feature or request label May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants