Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Volume retention policy on MongoDbInstance construct #483

Open
2 tasks
ddneilson opened this issue Jun 21, 2021 · 0 comments
Open
2 tasks

Expose Volume retention policy on MongoDbInstance construct #483

ddneilson opened this issue Jun 21, 2021 · 0 comments
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@ddneilson
Copy link
Contributor

The CDK changed the EC2 Volume to retain by default, and added a retention policy property to the EC2 Volume construct about four months ago. The RFDK's MongoDbInstance creates an EC2 Volume, but does not expose a way for the retention policy for the Volume to be set.

As a result, MongoDbInstances created by the RFDK will leave behind a data volume when destroyed.

Use Case

Cleanup after automated testing.

Proposed Solution

Just expose the removalPolicy property in the MongoDbInstanceNewVolumeProps.

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@ddneilson ddneilson added needs-triage This issue or PR still needs to be triaged. feature-request A feature should be added or improved. labels Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ddneilson