Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependency for symfony/filesystem #2941

Open
kkmuffme opened this issue Jun 11, 2024 · 2 comments
Open

Missing dependency for symfony/filesystem #2941

kkmuffme opened this issue Jun 11, 2024 · 2 comments
Assignees
Labels
bug This issue is a bug. p2 This is a standard priority issue queued This issues is on the AWS team's backlog

Comments

@kkmuffme
Copy link

Describe the bug

https://github.com/aws/aws-sdk-php/blob/master/composer.json

https://github.com/aws/aws-sdk-php/tree/master/src/Script/Composer#removing-unused-services
uses symfony filesystem under the hood though - therefore currently this leads to a fatal error:
https://github.com/aws/aws-sdk-php/blob/master/src/Script/Composer/Composer.php#L24 (https://github.com/aws/aws-sdk-php/blob/master/src/Script/Composer/Composer.php#L6)

Expected Behavior

no error

Current Behavior

Fatal error

Reproduction Steps

https://github.com/aws/aws-sdk-php/tree/master/src/Script/Composer#removing-unused-services

Possible Solution

As a temporary workaround one can install symfony/filesystem as dependency manually

As a permanent solution this package should be added to the SDK dependencies (require, not require-dev)

Additional Information/Context

No response

SDK version used

3.312.0

Environment details (Version of PHP (php -v)? OS name and version, etc.)

8.3.x - error is version independent

@kkmuffme kkmuffme added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jun 11, 2024
@yenfryherrerafeliz
Copy link
Contributor

Hi @kkmuffme, thanks for opening this issue. Our package.json requires "composer/composer", which we can see here, and this dependency requires symfony/filesystem, which we can confirm here. This mean that this dependency should always be present once you resolve the dependencies for the SDK. Please let me know if that is not the case for you, and if so, can you please explain why?

Thanks!

@yenfryherrerafeliz yenfryherrerafeliz self-assigned this Jun 11, 2024
@yenfryherrerafeliz yenfryherrerafeliz added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jun 11, 2024
@kkmuffme
Copy link
Author

kkmuffme commented Jun 11, 2024

Our package.json requires "composer/composer"

This is only in require-dev not in require and therefore doesn't exist when bundling the package for release with --no-dev flag

@yenfryherrerafeliz yenfryherrerafeliz added needs-review p2 This is a standard priority issue and removed response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. labels Jun 11, 2024
@RanVaknin RanVaknin added queued This issues is on the AWS team's backlog bug This issue is a bug. and removed needs-review labels Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p2 This is a standard priority issue queued This issues is on the AWS team's backlog
Projects
None yet
Development

No branches or pull requests

3 participants