Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReconciliationSource resources using the restic mover will silently fail under certain conditions. #1454

Closed
benfiola opened this issue Nov 13, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@benfiola
Copy link
Contributor

benfiola commented Nov 13, 2024

Describe the bug
It appears that that the restic has a code path where errors are inadvertently suppressed. This code path includes cases where a ReplicationSource might have invalid data - which was the case when I accidentally left spec.restic.copyMethod unset. Ultimately, I had to clone the repo locally and run the controller with a debugger to determine why this resource was failing to reconcile.

Steps to reproduce
Create a ReplicationSource using restic but without setting spec.restic.copyMethod.

Expected behavior
The resource should be reconciled (e.g., the data moving jobs should be created).

Actual results
The resource is updated to the Transitioning state and then nothing happens.

@tesshuflower
Copy link
Contributor

Fixed by @benfiola in #1455

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants