Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReplicationSource/ReplicationDestination name length limit #1470

Open
tesshuflower opened this issue Nov 26, 2024 · 1 comment · May be fixed by #1519
Open

Fix ReplicationSource/ReplicationDestination name length limit #1470

tesshuflower opened this issue Nov 26, 2024 · 1 comment · May be fixed by #1519
Labels
bug Something isn't working

Comments

@tesshuflower
Copy link
Contributor

Describe the bug

When a replicationsource or replicationdestination has a name that is too long, this can produce a failure as the subsequent created resources can have names that are too long.

  • First thing I think that is hit is when we create a mover job. Jobs will use labels based on the job name, and labels have a key length limit of 63 characters. If we create a job with volsync-src-<cr name> then we can easily hit this limit
  • After this, do we hit any other errors? Not sure what other resources can be affected - we could also hit a next level of name length limit when objects we create (volume snapshots, service accounts, pvcs etc) hit the kubernetes object name length limit.

Discussion:

  • Possibly generate a name for the job using a hash
  • Save the job name somewhere in status so users can find it
  • What about migration? Existing jobs may still use the old name and still be running when volsync is updated to a new version with this fix
  • What about other objects?
@tesshuflower tesshuflower added the bug Something isn't working label Nov 26, 2024
@svenihoney
Copy link

I exactly hit this problem today when trying to migrate my home-assistant-config volume in namespace home-assistant. The service cannot be created.

@tesshuflower tesshuflower linked a pull request Jan 13, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants