Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify symbol specification in config spec #85

Open
bbusschots opened this issue Apr 14, 2024 · 2 comments
Open

Simplify symbol specification in config spec #85

bbusschots opened this issue Apr 14, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@bbusschots
Copy link
Contributor

For the separator and padding characters, the symbol alone can be used to infer the type:

  • Not present or explicitly empty means none
  • a string of exactly 1 character or an array with exactly one string of length 1 means fixed
  • a string with more than one character or an array with more than one string of length one means random from that set

For arrays of strings, if the strings are longer than a single character, the first character is used.

@del-leehopper
Copy link

As part of this enhancement, I would recommend the drop-down field "Padding Type" be set to "Use Separator Character" as default.

If you think logically, if someone has manually entered characters in the separator field, they are more likely to want to use those same characters in the padding field. Previously, I would copy/paste into that field as I didn't even realise there was a drop-down.

If someone specifically wants different padding characters, they will 'look' for this drop-down - however, someone who isn't looking for this feature will not. Hence, defaulting to "Use Separator Character" is the more logical default option.

@hepabolu
Copy link
Contributor

@bbusschots I disagree about the inferring the type from the value of the separator char (and the padding char for that matter). That was the original setup and it gave me a headache trying to getting the code to handle this setup correctly. That's why I split the characters and the type to different variables/elements.

I do like the idea of having one element for the character/alphabet. It seems a good simplification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants