From 88e7706aceb8abb8eddf943fc42b55353879dd5a Mon Sep 17 00:00:00 2001 From: Alexander Bias Date: Sat, 11 May 2024 12:41:38 +0200 Subject: [PATCH] Review changes --- CHANGES.md | 1 + ...boost_union_smartmenusettings_menus_management.feature | 8 ++++---- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index 63a28b8ab06..1d6ec9600c8 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -6,6 +6,7 @@ Changes ### Unreleased +* 2024-05-11 - Improvement: Smart menu "locations" must be filled with a value, resolves #404 * 2024-05-10 - Bugfix: Do not show empty smart menus to users, resolves #405 * 2024-05-09 - Bugfix: Smart menu menubar overlaid course index, resolves #607 * 2024-04-27 - Improvement: Add navigation to policy overview page, resolves #633 diff --git a/tests/behat/theme_boost_union_smartmenusettings_menus_management.feature b/tests/behat/theme_boost_union_smartmenusettings_menus_management.feature index 0f768ccc43c..fa88708a0b4 100644 --- a/tests/behat/theme_boost_union_smartmenusettings_menus_management.feature +++ b/tests/behat/theme_boost_union_smartmenusettings_menus_management.feature @@ -133,17 +133,17 @@ Feature: Configuring the theme_boost_union plugin on the "Smart menus" page, man And "Enrolled courses" "table_row" should appear before "Completed courses" "table_row" @javascript - Scenario: Smartmenus: Menus: Management - Make location field required + Scenario: Smartmenus: Menus: Management - Make sure that location field is filled When I log in as "admin" And I navigate to smart menus And I click on "Create menu" "button" And I set the following fields to these values: | Title | Links | And I click on "Save and return" "button" - And I should see "Required" in the "#fitem_id_location" "css_element" - Then I set the field "Menu location(s)" to "Main" + Then I should see "Required" in the "#fitem_id_location" "css_element" + And I set the field "Menu location(s)" to "Main" And I click on "Save and return" "button" - And I should see "Links" in the "smartmenus" "table" + Then I should see "Links" in the "smartmenus" "table" And I set "Links" smart menu items with the following fields to these values: | Title | Info | | Menu item type | Heading |