Migrate back to Cloudflare Workers #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benvinegar
force-pushed
the
migrate-to-worker
branch
from
a75c372 to
1518553
Compare
benvinegar
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3 #147 +/- ##
==========================================
- Coverage 87.00% 86.47% -0.54%
==========================================
Files 38 37 -1
Lines 2439 2454 +15
Branches 302 301 -1
==========================================
Hits 2122 2122
- Misses 309 325 +16
+ Partials 8 7 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #134.
This would introduce breaking changes because it deploys to a Cloudflare Worker instead of a Pages project – you would need to create the Worker. But the good news is the data (Analytics Engine) will be unaffected.
Not sure I want to introduce another major version (3.x) for this though.