Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Play sound file at the moment that SCT and MCT are reached (also when eliminated) #6

Open
bkoelman opened this issue Jan 18, 2016 · 2 comments
Open

Play sound file at the moment that SCT and MCT are reached (also when eliminated) #6

bkoelman opened this issue Jan 18, 2016 · 2 comments
Labels
help wanted

Comments

@bkoelman
Copy link
Owner

Requires additional background timers. EliminationTracker seems like a good place to implement this.
@bkoelman
Copy link
Owner Author

Considerations:

  1. When eliminated due to MaximumCourseTimeElapsed, which sound file (PlayEliminated or PlayMctPassed) must be played?
  2. Extra input validation?: MCT must always be higher than SCT (both empty is allowed)
  3. Extra input validation: MCT can only be specified when SCT is also specified? or maybe the other way around?

bkoelman pushed a commit that referenced this issue Jan 21, 2016
Fixes #6
a212a02
bkoelman pushed a commit that referenced this issue Jan 22, 2016
Fixes #6
bf84ccd
@bkoelman
Copy link
Owner Author

  1. As PlayMctPassed is the reson of what is happening, that seems most appropriate to me.
  2. Sounds reasonable to me to add this.
  3. Not sure. Holding off merge of PR until this is clarified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bkoelman